Skip to content

fix: use different bundle ID for dev runner#1806

Open
nmggithub wants to merge 1 commit intopingdotgg:mainfrom
nmggithub:separate-dev-runner-bundle-id
Open

fix: use different bundle ID for dev runner#1806
nmggithub wants to merge 1 commit intopingdotgg:mainfrom
nmggithub:separate-dev-runner-bundle-id

Conversation

@nmggithub
Copy link
Copy Markdown
Contributor

@nmggithub nmggithub commented Apr 7, 2026

What Changed

This just makes our dev runner use a different bundle ID.

Why

macOS expects different apps to have different bundle IDs. When we break this expectation, that may lead to bad side effects. It's hard to say specifically, as the OS likely makes a multitude of decisions based on this in all different areas. Ultimately, we just don't want macOS to confuse our dev runner for our built app or visa versa.

UI Changes

N/A

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk: only changes the macOS CFBundleIdentifier used by the dev launcher to avoid OS-level app identity collisions; runtime behavior should be unaffected aside from app identity.

Overview
Updates the desktop Electron launcher to use a different macOS bundle ID in development (com.t3tools.t3code.dev) while keeping the production bundle ID unchanged.

This prevents macOS from treating the dev runner and built app as the same application (and avoids related caching/registration side effects) when patching Info.plist during launcher build.

Reviewed by Cursor Bugbot for commit 862f65c. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Use a separate bundle ID for the dev Electron runner

In electron-launcher.mjs, APP_BUNDLE_ID is now set to com.t3tools.t3code.dev in development mode and com.t3tools.t3code in production. This prevents the dev runner from conflicting with the production app on macOS.

Macroscope summarized 862f65c.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ffc6702e-56d4-40d2-be23-92374fdda0f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 7, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 862f65c. Configure here.

const isDevelopment = Boolean(process.env.VITE_DEV_SERVER_URL);
const APP_DISPLAY_NAME = isDevelopment ? "T3 Code (Dev)" : "T3 Code (Alpha)";
const APP_BUNDLE_ID = "com.t3tools.t3code";
const APP_BUNDLE_ID = isDevelopment ? "com.t3tools.t3code.dev" : "com.t3tools.t3code";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale cache serves old bundle ID without rebuild

Medium Severity

LAUNCHER_VERSION remains at 1 after changing the bundle ID logic. The build cache (expectedMetadata) only checks launcherVersion, source path, source mtime, and icon mtime — not the bundle ID itself. Developers with an existing cached .electron-runtime app bundle won't get a rebuild, so their dev runner will keep the old com.t3tools.t3code bundle ID, defeating the purpose of this change. Bumping LAUNCHER_VERSION to 2 would force a cache invalidation and rebuild.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 862f65c. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit weird to do a whole version jump for this, but, given the dev runner is all this file is for (per the comment at the top of it), perhaps it's ok.

@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 7, 2026

Approvability

Verdict: Needs human review

Simple dev tooling change to separate bundle IDs, but an unresolved review comment correctly identifies that LAUNCHER_VERSION should be bumped to force cache invalidation. Without this fix, existing cached builds won't pick up the new bundle ID.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant