Skip to content

fix: use different bundle ID for dev runner #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Apr 10, 2026
+1 −1
Merged

fix: use different bundle ID for dev runner #1806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/scripts/electron-launcher.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { fileURLToPath } from "node:url";

const isDevelopment = Boolean(process.env.VITE_DEV_SERVER_URL);
const APP_DISPLAY_NAME = isDevelopment ? "T3 Code (Dev)" : "T3 Code (Alpha)";
const APP_BUNDLE_ID = "com.t3tools.t3code";
const APP_BUNDLE_ID = isDevelopment ? "com.t3tools.t3code.dev" : "com.t3tools.t3code";
Copy link
Copy Markdown
Contributor

@cursor cursor bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale cache serves old bundle ID without rebuild

Medium Severity

LAUNCHER_VERSION remains at 1 after changing the bundle ID logic. The build cache (expectedMetadata) only checks launcherVersion, source path, source mtime, and icon mtime — not the bundle ID itself. Developers with an existing cached .electron-runtime app bundle won't get a rebuild, so their dev runner will keep the old com.t3tools.t3code bundle ID, defeating the purpose of this change. Bumping LAUNCHER_VERSION to 2 would force a cache invalidation and rebuild.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 862f65c. Configure here.

Copy link
Copy Markdown
Contributor Author

@nmggithub nmggithub Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit weird to do a whole version jump for this, but, given the dev runner is all this file is for (per the comment at the top of it), perhaps it's ok.

const LAUNCHER_VERSION = 1;

const __dirname = dirname(fileURLToPath(import.meta.url));
Expand Down
Loading