Fix: disable JarURLConnection caching in GuidelineIO to prevent concurrent scan failures#151
Open
Fix: disable JarURLConnection caching in GuidelineIO to prevent concurrent scan failures#151
Conversation
…e issues getJarFile() returns a shared, cached JarFile instance by default. When one caller closes it via try-with-resources, concurrent callers that received the same cached instance fail with "zip file closed". Setting setUseCaches(false) before getJarFile() ensures each JarURLConnection opens its own independent JarFile instance. Fixes: tls-attacker/TLS-Scanner-Development#772 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GuidelineIO.listXmlFiles()callsjarConnection.getJarFile()which, by default, returns a shared, cachedJarFileinstance. When oneTlsServerScannerinstance finishes and its try-with-resources block closes theJarFile, any concurrent scanner that received the same cached handle fails with:This only manifests when running multiple concurrent scans from a JAR (production deployments), not in development mode where the file protocol is used.
Fix
Add
jarConnection.setUseCaches(false)before callinggetJarFile(). This causes the JDK to open a fresh, independentJarFilefor each connection, so closing one does not affect others.References
This PR was created with AI assistance.