Skip to content

Fix: disable JarURLConnection caching in GuidelineIO to prevent concurrent scan failures #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ic0ns wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: disable JarURLConnection caching in GuidelineIO to prevent concurrent scan failures #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/de/rub/nds/scanner/core/guideline/GuidelineIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,12 @@ private static List<String> listXmlFiles(ClassLoader classLoader, String folder)
.forEach(p -> xmlFilePaths.add(folder + "/" + p.getFileName().toString()));
}
} else if ("jar".equals(protocol)) {
// Running from a jar
// Running from a jar. Disable caching so each connection opens its own
// JarFile instance; the default cached instance is shared across threads
// and closing it (via try-with-resources) causes "zip file closed" errors
// in concurrent callers.
JarURLConnection jarConnection = (JarURLConnection) url.openConnection();
jarConnection.setUseCaches(false);
try (JarFile jarFile = jarConnection.getJarFile()) {
Enumeration<JarEntry> entries = jarFile.entries();
while (entries.hasMoreElements()) {
Expand Down