Skip to content

CS-180 [Bug] Document findings do not link correctly #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marfuen merged 4 commits into from
Mar 12, 2026
Merged

CS-180 [Bug] Document findings do not link correctly #2289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2189fd
fix(api): normalize evidence form types in framework findings
chasprowebdev Mar 12, 2026
2e05c6e
fix(app): remove hypen/underscore from finding label
chasprowebdev Mar 12, 2026
bc4bca1
Merge branch 'main' of https://github.com/trycompai/comp into chas/do…
chasprowebdev Mar 12, 2026
b31353d
Merge branch 'main' into chas/document-findings
Marfuen Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion apps/api/src/frameworks/frameworks-scores.helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {
evidenceFormDefinitionList,
meetingSubTypeValues,
toDbEvidenceFormType,
toExternalEvidenceFormType,
} from '@comp/company';
import { db } from '@trycompai/db';
import { filterComplianceMembers } from '../utils/compliance-filters';
Expand Down Expand Up @@ -142,14 +143,27 @@ async function computeDocumentsScore(organizationId: string) {
}

async function getOrganizationFindings(organizationId: string) {
return db.finding.findMany({
const findings = await db.finding.findMany({
where: { organizationId },
include: {
task: { select: { id: true, title: true } },
evidenceSubmission: { select: { id: true, formType: true } },
},
orderBy: [{ status: 'asc' }, { createdAt: 'desc' }],
});

return findings.map((finding) => ({
...finding,
evidenceFormType: toExternalEvidenceFormType(finding.evidenceFormType),
evidenceSubmission: finding.evidenceSubmission
? {
...finding.evidenceSubmission,
formType:
toExternalEvidenceFormType(finding.evidenceSubmission.formType) ??
'meeting',
}
: null,
}));
}

export async function getCurrentMember(
Expand Down
4 changes: 2 additions & 2 deletions apps/app/src/app/(app)/[orgId]/frameworks/components/FindingsOverview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ function FindingsList({
<span className="text-sm font-medium text-foreground line-clamp-1">
{finding.task?.title ??
(finding.evidenceFormType
? `Document: ${finding.evidenceFormType}`
? `Document: ${finding.evidenceFormType.replace(/-/g, ' ')}`
: finding.evidenceSubmission
? `Document: ${finding.evidenceSubmission.formType}`
? `Document: ${finding.evidenceSubmission.formType.replace(/-/g, ' ')}`
: 'Finding')}
</span>
<p className="text-xs text-muted-foreground mt-1 line-clamp-2">
Expand Down
Loading