apollo_propeller: rename did_broadcast_my_shard to did_broadcast_my_unit

[sirandreww-starkware]

Note

Low Risk
Low risk refactor that only renames internal ReconstructionState flag/method used to prevent double-broadcasting, with no functional logic changes expected.

Overview
Renames the internal reconstruction flag from did_broadcast_my_shard to did_broadcast_my_unit and updates all call sites in message_processor.rs to reflect that it tracks whether our unit has already been broadcast.

This is a purely semantic cleanup to align naming with the PropellerUnit terminology, leaving the broadcast gating behavior unchanged.

^{Reviewed by Cursor Bugbot for commit 3ece279. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

• apollo_propeller: rename num_shards() to num_units(), num_total_shards to num_total_units #13602
• apollo_propeller: rename my_shard_proof to my_unit_proof #13601
• apollo_propeller: fix merkle.rs module doc to say 'proofs for units' #13600
• apollo_propeller: rename unit_id to unit_index in get_my_unit_index_given_publisher #13599
• apollo_propeller: fix TODO comment shard_owner to unit_owner #13598
• apollo_propeller: rename test_get_peer_for_unit_id to test_get_peer_for_unit_index #13597
• apollo_propeller: fix get_peer_for_unit_index doc to say 'total_units-1' #13596
• apollo_propeller: fix sharding.rs error message to say 'total units' instead of 'total shards' #13595
• apollo_propeller: rename MY_SHARD_INDEX to MY_UNIT_INDEX in sharding_test.rs #13594
• apollo_propeller: fix tree_test.rs comments to say 'unit index' instead of 'shard index' #13593
• apollo_propeller: fix expect messages to say 'unit index' instead of 'shard index' #13592
• apollo_propeller: rename shard_index params and test case names to unit_index in tree_test.rs #13591
• apollo_propeller: rename local shard_index/shard_id vars to unit_index/unit_id in tree.rs #13590
• apollo_propeller: rename get_my_shard_index_given_publisher to get_my_unit_index_given_publisher #13589
• apollo_propeller: rename get_peer_for_shard_index to get_peer_for_unit_index #13588
• apollo_propeller: rename is_my_shard to is_my_unit #13587
• apollo_propeller: rename my_shard_index to my_unit_index #13586
• apollo_propeller: rename ShardIndex to UnitIndex, ShardIndexOutOfBounds to UnitIndexOutOfBounds #13585
• apollo_protobuf: fix PropellerUnit proto comments to say 'unit' instead of 'shard' #13540
• apollo_propeller: fix sharding_test comment to say 'units' instead of 'shards' #13536
• apollo_propeller: fix typo 'form' to 'from' in SignatureVerificationError message #13535
• apollo_propeller: rename test_duplicate_shard_rejected to test_duplicate_unit_rejected #13534
• apollo_propeller: fix remaining tree.rs comments to say 'unit' instead of 'shard' #13533
• apollo_propeller: fix get_peer_for_shard_index doc comment to say 'unit' #13532
• apollo_propeller: rename shard_count to unit_count in should_build and should_receive #13531
• apollo_propeller: fix PropellerScheduleManager doc comments to say 'units' #13530
• apollo_propeller: remove incorrect tree.rs module doc comment #13529
• apollo_propeller: rename shard_count/total_shards to unit_count/total_units #13528
• apollo_propeller: rename shards param to units in reconstruct_blocking #13527
• apollo_propeller: fix PostConstruction doc comment to say 'units' #13526
• apollo_propeller: rename DuplicateShard/ReceivedSelfPublishedShard variants #13525
• apollo_propeller: fix UnitValidationError error messages to say 'unit' instead of 'shard' #13524
• apollo_propeller: fix UnitValidationError doc comment to say 'unit verification' #13523
• apollo_propeller: fix SignatureVerificationError error message to say 'unit' #13522
• apollo_propeller: fix Event doc comments to say 'units' instead of 'shards' #13520
• apollo_propeller: rename received_shards param to received_units in reconstruct_data_shards #13509
• apollo_propeller: rename ShardSendFailed/ShardValidationFailed event variants #13508
• apollo_propeller: rename ShardSignatureVerificationError to SignatureVerificationError #13507
• apollo_propeller: rename ShardValidationError to UnitValidationError #13506
• apollo_propeller: rename ShardPublishError to UnitPublishError #13505
• apollo_propeller: rename shards_received metric to units_received #13504
• apollo_propeller: rename validate_shard to validate_unit in UnitValidator #13503
• apollo_propeller: rename local vars shards/shard_count to units/unit_count in handle_action #13502
• apollo_propeller: rename maybe_broadcast_my_shard to maybe_broadcast_my_unit #13501
• apollo_propeller: rename num_held_shards to num_held_units #13500
• apollo_propeller: rename did_broadcast_my_shard to did_broadcast_my_unit #13499 👈 (View in Graphite)
• apollo_propeller: rename received_shards to received_units in ReconstructionState #13498
• apollo_propeller: fix tree.rs comments to use 'unit' instead of 'shard' #13497
• apollo_propeller: fix unit_validator.rs comments to use 'unit' instead of 'shard' #13496
• apollo_propeller: fix message_processor.rs comments to use 'unit' instead of 'shard' #13495
• apollo_propeller: fix engine.rs comments to use 'unit' instead of 'shard' for PropellerUnit #13494
• apollo_propeller: replace local Stake type alias with StakingWeight from starknet_api #13037
• apollo_propeller: multiple shards per peer #12914
• apollo_propeller: changed CommitteeId to be a hash value #12913
• apollo_propeller: renamed Channel to CommitteeId #12911
• apollo_propeller: widen ShardIndex from u32 to u64 #12878
• apollo_propeller: e2e tests #12837 : 1 other dependent PR (#12838 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[guy-starkware]

@guy-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware and ShahakShama).

[graphite-app]

Merge activity

• Apr 9, 11:31 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.