apollo_propeller: rename ShardValidationError to UnitValidationError#13506
Conversation
This was referenced Mar 26, 2026
|
This change is |
This was referenced Mar 26, 2026
Open
Contributor
Author
This was referenced Mar 26, 2026
sirandreww-starkware
requested review from
ShahakShama,
guy-starkware and
noamsp-starkware
sirandreww-starkware
force-pushed
the
03-26-apollo_propeller_rename_shardvalidationerror_to_unitvalidationerror
branch
from
7421004 to
6f9b12e
Compare
This was referenced Mar 26, 2026
This was referenced Mar 26, 2026
Open
sirandreww-starkware
force-pushed
the
03-26-apollo_propeller_rename_shardvalidationerror_to_unitvalidationerror
branch
from
6f9b12e to
f09ecd8
Compare
sirandreww-starkware
force-pushed
the
03-26-apollo_propeller_rename_shardvalidationerror_to_unitvalidationerror
branch
from
f09ecd8 to
f7371b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Mechanical rename of an error type and its references; behavior should be unchanged aside from API/typing updates for downstream callers.
Overview
Renames
ShardValidationErrortoUnitValidationErroracrossapollo_propeller, updating all public re-exports, function signatures, and internal type aliases to use the new name.Updates the
Event::ShardValidationFailedpayload and associated validation code/tests (tree,unit,unit_validator,message_processor) to emit/expectUnitValidationErrorvariants without changing validation behavior.Written by Cursor Bugbot for commit f7371b3. This will update automatically on new commits. Configure here.