apollo_propeller: fix Event doc comments to say 'units' instead of 'shards'#13520
Conversation
This was referenced Mar 26, 2026
Open
Merged
Merged
Contributor
Author
This was referenced Mar 26, 2026
This was referenced Apr 6, 2026
apollo_propeller: rename shard_index params and test case names to unit_index in tree_test.rs
#13591
Draft
Draft
e7b3001 to
08e7bb6
Compare
6a876ca to
65bb7ab
Compare
973d1c8 to
4674a00
Compare
1420f4f to
59cd33f
Compare
guy-starkware
approved these changes
Apr 9, 2026
Contributor
guy-starkware
left a comment
There was a problem hiding this comment.
@guy-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware and ShahakShama).
59cd33f to
2feab23
Compare
d653041 to
a0894e0
Compare
10a2da2 to
bf1cc23
Compare
a0894e0 to
1a6ac8d
Compare
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 6c59003. Bugbot is set up for automated code reviews on this repo. Configure here. |
1a6ac8d to
6c59003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Low risk: documentation-only change that updates
Eventvariant doc comments without modifying any runtime behavior.Overview
Updates
apollo_propellerEventdocumentation to consistently refer to reconstructed data as units (not shards) forMessageReceivedandMessageReconstructionFailed.Reviewed by Cursor Bugbot for commit a0894e0. Bugbot is set up for automated code reviews on this repo. Configure here.