Skip to content

apollo_propeller: fix Event doc comments to say 'units' instead of 'shards'#13520

Open
sirandreww-starkware wants to merge 1 commit into03-26-apollo_propeller_rename_received_shards_param_to_received_units_in_reconstruct_data_shardsfrom
03-26-apollo_propeller_fix_event_doc_comments_to_say_units_instead_of_shards_
Open

apollo_propeller: fix Event doc comments to say 'units' instead of 'shards'#13520
sirandreww-starkware wants to merge 1 commit into03-26-apollo_propeller_rename_received_shards_param_to_received_units_in_reconstruct_data_shardsfrom
03-26-apollo_propeller_fix_event_doc_comments_to_say_units_instead_of_shards_

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

@sirandreww-starkware sirandreww-starkware commented Mar 26, 2026

Note

Low Risk
Low risk: documentation-only change that updates Event variant doc comments without modifying any runtime behavior.

Overview
Updates apollo_propeller Event documentation to consistently refer to reconstructed data as units (not shards) for MessageReceived and MessageReconstructionFailed.

Reviewed by Cursor Bugbot for commit a0894e0. Bugbot is set up for automated code reviews on this repo. Configure here.

This was referenced Mar 26, 2026
@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Mar 26, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sirandreww-starkware sirandreww-starkware changed the base branch from 03-26-apollo_propeller_rename_received_shards_param_to_received_units_in_reconstruct_data_shards to graphite-base/13520 April 6, 2026 07:12
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_event_doc_comments_to_say_units_instead_of_shards_ branch from e7b3001 to 08e7bb6 Compare April 6, 2026 07:12
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_event_doc_comments_to_say_units_instead_of_shards_ branch 3 times, most recently from 973d1c8 to 4674a00 Compare April 9, 2026 10:07
Copy link
Copy Markdown
Contributor

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware and ShahakShama).

@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_event_doc_comments_to_say_units_instead_of_shards_ branch 3 times, most recently from d653041 to a0894e0 Compare April 12, 2026 06:36
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13520 to 03-26-apollo_propeller_rename_received_shards_param_to_received_units_in_reconstruct_data_shards April 12, 2026 06:37
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_received_shards_param_to_received_units_in_reconstruct_data_shards branch from 10a2da2 to bf1cc23 Compare April 20, 2026 05:57
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_event_doc_comments_to_say_units_instead_of_shards_ branch from a0894e0 to 1a6ac8d Compare April 20, 2026 05:57
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 20, 2026

PR Summary

Low Risk
Documentation-only change with no functional or behavioral impact.

Overview
Updates apollo_propeller Event variant doc comments in types.rs to refer to reconstructing messages from units (not shards), matching current terminology.

Reviewed by Cursor Bugbot for commit 6c59003. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_event_doc_comments_to_say_units_instead_of_shards_ branch from 1a6ac8d to 6c59003 Compare April 20, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants